Skip to content

Conversation

@keyur9
Copy link
Member

@keyur9 keyur9 commented Feb 24, 2020

Add: Support for capturing outgoing requests
Refactor: Update README.md
Bump version to 1.2.6

Add: Support for capturing outgoing requests
Refactor: Update README.md
Bump version to 1.2.6
@keyur9 keyur9 requested a review from dkm199 February 24, 2020 22:48
Copy link
Member

@dgilling dgilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't batch on AWS Lambda since the process will die. Best just to do async. Does it work? Maybe if implemented that way, we can get away with it with short flush windows?

@xinghengwang
Copy link
Member

derric asked to take a look. but looks like mostly a copy of the stuff from Moesif-express. I don't know if this works for AWS. This is tested, right?

@keyur9
Copy link
Member Author

keyur9 commented Feb 24, 2020

Yes, it is tested for AWS and it works fine.

Add: Support for lambda async functions
Refactor: Update README.md
Refactor: Add async function handler example
@dgilling dgilling merged commit f8d6c3e into master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants