[0046] 修复 gf fmt 将 quasiquote 内注释输出为 (*comment*)#794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
修复
gf fmt在格式化 quasiquote/quote 内的;;注释时，将注释错误输出为(*comment* \"...\")代码的问题。Changes
tools/fmt/liii/goldfmt-format.scm：comment-datum?谓词，识别(*comment* \"...\")形式format-reader-datum-inline和format-reader-datum-at中还原;;注释reader-datum-contains-newline-marker?以识别注释节点tools/fmt/tests/liii/goldfmt-format/format-string-test.scm：添加回归测试devel/0046.md：添加开发文档Test Plan
gf fmt --dry-run不再输出*comment*tools/fmt下全部 609 个 checks 通过