fix: add bounds safety net in graphical_select to prevent undefined behavior#3047
Closed
Shubham-py404 wants to merge 1 commit intoMoganLab:mainfrom
Closed
fix: add bounds safety net in graphical_select to prevent undefined behavior#3047Shubham-py404 wants to merge 1 commit intoMoganLab:mainfrom
Shubham-py404 wants to merge 1 commit intoMoganLab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the array out-of-bounds issue when interacting with ellipses using the selection tools.
As discussed by @GatsbyUSTC in the previously closed PR (#2948), hardcoding the array initialization to 3 is a temporary workaround. Instead, this PR implements a permanent safety net inside curve_box_rep::graphical_select in graphics_boxes.cpp.
Before the array indices are calculated, the code now checks if np exceeds the actual size of the abs array using N(abs). If it does, it truncates np to prevent the loop from accessing unallocated memory, fully eliminating the undefined behavior and the resulting infinite loop/crash.