Skip to content

[204_30] todo 块在深色模式下单独覆盖颜色#3089

Merged
da-liii merged 1 commit intomainfrom
cms/204_30/dark_todo
Apr 1, 2026
Merged

[204_30] todo 块在深色模式下单独覆盖颜色#3089
da-liii merged 1 commit intomainfrom
cms/204_30/dark_todo

Conversation

@MoonL79
Copy link
Copy Markdown
Contributor

@MoonL79 MoonL79 commented Apr 1, 2026

No description provided.

@MoonL79 MoonL79 self-assigned this Apr 1, 2026
@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Apr 1, 2026

Greptile Summary

本 PR 为 todo 块在深色主题下补充了独立的前景色(todo-color)和背景色(todo-bg-color)覆盖,使其在深色模式和浅色模式下均保持良好的视觉对比度。

  • dark.ts 中新增 todo-color: #ffb3b3(浅粉红,适合暗背景下的文字)和 todo-bg-color: #5a1f1f(深红色背景),覆盖 std-markup.ts 中的默认值(dark red / pastel red
  • 改动方式与已有的 version-notice-bg-color / version-notice-fg-color 模式完全一致,仅通过主题变量覆盖,不影响浅色模式下的默认效果
  • devel/204_30.md 中补充了完整的测试步骤(测试项十)及 What/Why/How 开发说明

Confidence Score: 5/5

改动极小且模式成熟,可安全合并

仅两处变量赋值,逻辑清晰,与项目已有深色主题颜色覆盖模式完全一致,无逻辑错误。唯一发现为一处尾随空格(P2),不影响功能。

无需特别关注的文件

Important Files Changed

Filename Overview
TeXmacs/packages/themes/dark/dark.ts 新增 todo-color(#ffb3b3)和 todo-bg-color(#5a1f1f)两个深色主题颜色变量覆盖,逻辑正确,与既有模式一致,仅有一处尾随空格的小问题
devel/204_30.md 补充了测试项十(todo 块深/浅色模式颜色验证)及本次改动的 What/Why/How 开发说明,内容清晰完整

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[渲染 todo 块] --> B{当前主题?}
    B -- 浅色主题 --> C["std-markup.ts 默认值\ntodo-color: dark red\ntodo-bg-color: pastel red"]
    B -- 深色主题 --> D["dark.ts 覆盖值\ntodo-color: #ffb3b3\ntodo-bg-color: #5a1f1f"]
    C --> E["render-todo 宏\n读取 todo-color / todo-bg-color 变量"]
    D --> E
    E --> F[渲染带颜色的 todo 块]
Loading

Reviews (1): Last reviewed commit: "[204_30] todo 块在深色模式下单独覆盖颜色" | Re-trigger Greptile

<assign|preview-bg-color|#5a7cc2>

<assign|table-selection-color|#5500ff10>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 空白行存在多余的尾随空格

第 96 行(table-selection-color 赋值后的空白行)包含尾随空格( ),与文件其他空白行风格不一致。

Suggested change

Copy link
Copy Markdown
Contributor

@da-liii da-liii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@da-liii da-liii merged commit 139d87c into main Apr 1, 2026
1 check passed
@da-liii da-liii deleted the cms/204_30/dark_todo branch April 1, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants