Conversation
Contributor
Greptile Summary本 PR 在已有聚光灯教程基础设施之上，完善了首次启动引导流程：新增 JSON 驱动的四步教程配置，支持 Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant TutorialEngine
participant Scheme
participant Prefs as UserPreferences
TutorialEngine->>TutorialEngine: showStep(requireAction step)
TutorialEngine->>TutorialEngine: updateCurrentStepGate()
TutorialEngine->>Prefs: reset_user_preference("tutorial:last-action")
TutorialEngine->>TutorialEngine: setNextEnabled(false)
TutorialEngine->>TutorialEngine: actionPollTimer.start(150ms)
User->>Scheme: kbd-magic-paste / ocr-paste / OCR button
Scheme->>Prefs: cpp-set-preference("tutorial:last-action", action)
loop Poll every 150ms
TutorialEngine->>Prefs: get_user_preference("tutorial:last-action")
alt action matches requiredAction
TutorialEngine->>TutorialEngine: completedActionSteps.insert(stepId)
TutorialEngine->>Prefs: reset_user_preference
TutorialEngine->>TutorialEngine: setNextEnabled(true)
TutorialEngine->>TutorialEngine: actionPollTimer.stop()
end
end
User->>TutorialEngine: Next button clicked
TutorialEngine->>TutorialEngine: showNextAvailableStep()
Reviews (2): Last reviewed commit: "补充文档" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
73
to
+75
| call ("ocr-to-latex-by-image", current_tree); | ||
| eval ("(when (defined? 'tutorial-notify-action) " | ||
| "(tutorial-notify-action \"ocr-paste\"))"); |
Contributor
There was a problem hiding this comment.
点击浮动菜单中的 OCR 按钮时，无论 ocr-to-latex-by-image 是否真正识别成功，tutorial-notify-action "ocr-paste" 都会被发送，用户因此可以在未完成有效 OCR 的情况下推进教程步骤。而键盘路径（generic-edit.scm 中的 ocr-paste）只有在剪贴板确实包含图片且处理成功时才发送通知，两者行为不一致。
建议让通知仅在 ocr-to-latex-by-image 执行成功后才发送，或在 Scheme 侧的 ocr-to-latex-by-image 内部统一处理通知，与 ocr-to-latex-by-cursor 的模式保持一致。
Comment on lines
+28
to
+38
| (tm-define (tutorial-prepare-magic-paste-demo) | ||
| (let* ((html-path (tutorial-magic-paste-demo-path)) | ||
| (html (utf8->cork (string-load html-path))) | ||
| (old-export (clipboard-get-export))) | ||
| (if (not tutorial-magic-paste-demo-opened?) | ||
| (begin | ||
| (new-document) | ||
| (set! tutorial-magic-paste-demo-opened? #t))) | ||
| (clipboard-set-export "verbatim") | ||
| (clipboard-set "primary" html) | ||
| (clipboard-set-export old-export))) |
Contributor
There was a problem hiding this comment.
clipboard-set-export "verbatim" 与 clipboard-set-export old-export 之间的 clipboard-set "primary" html 若抛出异常，导出模式将保持 "verbatim" 而无法恢复，影响后续粘贴操作。建议使用 dynamic-wind 保证清理代码必定执行：
(dynamic-wind
(lambda () (clipboard-set-export "verbatim"))
(lambda () (clipboard-set "primary" html))
(lambda () (clipboard-set-export old-export)))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.