[Bug AB#1475412]: [Infra][API Generator] Fixing type failing to generate correctly: unordered_map<optional<x>> #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexDenfordSkyboxLabs
requested review from
JakeShirley and
rlandav
as code owners
AlexDenfordSkyboxLabs
changed the title
rlandav
reviewed
Sep 10, 2025
tools/api-docs-generator-test-snapshots/test/optionals/__snapshots__/optionals.spec.ts.snap
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Fixed ms docs and ran npm change |
JakeShirley
approved these changes
Sep 10, 2025
rlandav
approved these changes
Sep 10, 2025
zachcampbellskyboxlabs
approved these changes
Sep 10, 2025
Contributor
zachcampbellskyboxlabs
left a comment
zachcampbellskyboxlabs
left a comment
There was a problem hiding this comment.
Looks good!
AlexDenfordSkyboxLabs
deleted the
sbl/alex.denford/record-optional-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small tweak to the moustache template to handle the undefined/optional within a Record/unordered_map. Tested on MCPE and it seems to be working correctly. (See PR: https://github.com/Mojang/Minecraftpe/pull/78575)