Skip to content

Bugfix/mshake#205

Open
97gamjak wants to merge 3 commits intodevfrom
bugfix/mshake
Open

Bugfix/mshake#205
97gamjak wants to merge 3 commits intodevfrom
bugfix/mshake

Conversation

@97gamjak
Copy link
Collaborator

No description provided.

@97gamjak 97gamjak requested a review from ape33 September 28, 2025 21:22
@codecov
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.99%. Comparing base (6075123) to head (f8ce73c).
⚠️ Report is 10 commits behind head on dev.

Files with missing lines Patch % Lines
src/constraints/mShake.cpp 0.00% 8 Missing ⚠️
src/constraints/constraints.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #205      +/-   ##
==========================================
- Coverage   74.09%   73.99%   -0.10%     
==========================================
  Files         328      283      -45     
  Lines       10772    10695      -77     
  Branches     3410     3309     -101     
==========================================
- Hits         7981     7914      -67     
- Misses       2754     2758       +4     
+ Partials       37       23      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ape33 ape33 linked an issue Sep 29, 2025 that may be closed by this pull request
@ape33 ape33 added the bug Something isn't working label Sep 29, 2025
Copy link
Member

@ape33 ape33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mshake does not converge for the example files provided in the linked issue, even after 1000 mshake iterations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MShake Error

2 participants