Guard Forknote parent blockchain branch depth#34
Merged
MoneroOcean merged 1 commit intoMay 29, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
depth(read fromtx_extraas an untrusted varint) from driving an uncheckedstd::vector::resizeduring deserialization which can OOM or abort the process.depthdirectly to size theblockchain_branchvector.Description
has_enough_blockchain_branch_bytes(Archive&, size_t, ...)that returntruefor saving and perform a remaining-bytes check for loading.PREPARE_CUSTOM_VECTOR_SERIALIZATION(mm_tag.depth, ...)so deserialization returnsfalsewhenmm_tag.depthclaims morecrypto::hashentries than remain.src/cryptonote_basic/cryptonote_basic.h(helper templates + early validation before resizingblockchain_branch).Testing
git diff --checkwhich completed successfully and showed no whitespace/style issues.npm install --no-audit --no-fund --no-package-lockto build the native addon and run tests, but the run was blocked by the npm registry returning403 Forbidden, so the native build/tests could not be executed in this environment.g++ -std=c++17 -I src -I src/contrib/epee/include -fsyntax-only src/cryptonote_basic/cryptonote_format_utils.cpp, but local compilation was prevented by missing Boost headers and restrictedapt-getaccess in the runner environment.Codex Task