Conversation
- Sécurité: hashage du PIN avec BCrypt dans AuthService et SubAccountService
- Sécurité: vérification PIN null/vide pour PARENT avant comparaison BCrypt
- Sécurité: suppression du HTTP Basic Auth inutile dans SecurityConfig
- Sécurité: endpoint /transactions/goal/{goalId} désormais authentifié avec vérification d'appartenance
- Bug: GoalService.deleteGoal() utilisait extractSubAccountAccountId au lieu de extractSubAccountId
- Bug: Operations.updateProgression() - ajout de RoundingMode.HALF_UP pour éviter ArithmeticException
- Bug: GoalService.confirmSavingMoneyTransfer() - comparaison BigDecimal avec compareTo() au lieu de ==
- Bug: MoneyService.updateMoney() - vérification d'autorisation CHILD utilise désormais l'ID du token
- Bug: AllowanceService.getAll() retourne une liste vide au lieu d'une exception si aucune allocation
- Qualité: @SpringBootApplication remplacé par @component sur les classes CRON, @EnableScheduling dans MoneybuddyApplication
- Typo: restPasswordConfirm renommé resetPasswordConfirm dans AuthService et AuthController
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- AddMoney: @notblank (invalide sur BigDecimal) remplace par @NotNull + @positive -> cause directe du UnexpectedTypeException qui generait le 500 - MoneyController: isAdd optionnel avec defaultValue true - GlobalExceptionHandler: handlers pour MissingServletRequestParameterException et UnexpectedTypeException -> retournent un 400 clair Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
INSERT LINK TO THE TICKET
Description
INSERT DESCRIPTION OF THE THING YOU WORKED ON
Modified environment variable
LIST HERE THE VERCEL ENV VAR YOU MODIFIED