Confusing error message when calling EmbeddedDocument.save

[meain]

Trying to save an EmbeddedDocumentField says NoneType cannot be saved.
Shouldn't it be rather EmbeddedDocumentField cannot be saved ?

[wojcikstefan]

Hi @meain! Would you please share the schema you're using and the exact scenario in which you're getting that error?

[meain]

@wojcikstefan Sorry, it was actually for EmbeddedDocument

class Platform(EmbeddedDocument):
    name = StringField(required=True)
    creds = DictField()
    enabled = BooleanField(default=False)

In [1]: from mongoengine import StringField, DictField, BooleanField, EmbeddedDocument

In [2]: class Platform(EmbeddedDocument):
   ...:     '''Field for each platform'''
   ...:     name = StringField(required=True)
   ...:     creds = DictField()
   ...:     enabled = BooleanField(default=False)
   ...:

In [3]: pl = Platform(name='s', creds={}, enabled=True)

In [4]: pl.save()
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-4-2b4ff9367580> in <module>()
----> 1 pl.save()

/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/mongoengine/document.pyc in save(self, *args, **kwargs)
     84
     85     def save(self, *args, **kwargs):
---> 86         self._instance.save(*args, **kwargs)
     87
     88     def reload(self, *args, **kwargs):

AttributeError: 'NoneType' object has no attribute 'save'

In [5]: type(pl)
Out[5]: __main__.Platform

In [6]: pl = Platform(name='s', creds={}, enabled=True).save()
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-6-b8bb49457e96> in <module>()
----> 1 pl = Platform(name='s', creds={}, enabled=True).save()

/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/mongoengine/document.pyc in save(self, *args, **kwargs)
     84
     85     def save(self, *args, **kwargs):
---> 86         self._instance.save(*args, **kwargs)
     87
     88     def reload(self, *args, **kwargs):

AttributeError: 'NoneType' object has no attribute 'save'

In [7]: type(Platform(name='s', creds={}, enabled=True))
Out[7]: __main__.Platform

[erdenezul]

embeddeddocument supposed to be not to call save method. Moreover, it should not have save method. both weird.

[erdenezul]

we should remove save() method from EmbeddedDocument class. I can submit PR