Fixed: ListField minus index assignment does not work #1119 #1128
Conversation
Add code to detect '-1' as a integer. Normalize negative index to regular list index Added list assignment test case
…changing database This resolved issue Please recall fix on: Saving document doesn't create new fields in existing collection MongoEngine#620 MongoEngine#1126
|
Nice! |
…reate new fields in existing collection MongoEngine#620 MongoEngine#1126
|
Updated the test case, and add example code to alter database for new field with default |
|
@iici-gli, something is wrong with |
Conflicts: AUTHORS docs/changelog.rst
|
@iici-gli hoefully one last request :) - please squash your commits |
|
'squash your commits'? How do I do it? |
|
Add new mark changed fix |
pull new changes from original
|
I don't think the git squash should be a blocker. The PR was reviewed already so I'm about to merge it. @iici-gli added another commit, unrelated to the PR. Please don't do that but open a PR per change. Anyway, this commit makes sense, so in the end I don't mind merging this PR including the new unrelated commit. @MongoEngine/mongoengine, any objection? |
…e#1217 The new fix reverted the change on BaseField to_mongo so that it will not force new field class to add kwargs to to_mongo function. The new derived field class to_mongo can support use_db_field and fields parameters as needed. Basically all field classes derived from ComplexBaseField support those parameters.
3 participants
Add code to detect '-1' as a integer.
Normalize negative index to regular list index
Added list assignment test case