Skip to content

Conversation

@bbenne10
Copy link
Contributor

Addresses #1217.

Review on Reviewable

@bbenne10
Copy link
Contributor Author

These failures don't appear to have anything to do with the code I pushed (and in fact seem to be related to pip 8.0? I'm not 100% sure)

@touilleMan
Copy link
Member

@bbenne10 That's it, pip 8.0 is messing your PR, you should rebase with master to solve this (I guess you will only have to rework a bit your changes in changelog.rst then)

Good job anyway 👍

@bbenne10
Copy link
Contributor Author

Rebased onto master and pushed. No conflicts, so I suppose we're just waiting on Travis at this point. Thanks for the suggestion.

touilleMan added a commit that referenced this pull request Jan 26, 2016
Curry **kwargs through to_mongo on fields
@touilleMan touilleMan merged commit c946b06 into MongoEngine:master Jan 26, 2016
@touilleMan
Copy link
Member

Merged, thx !

@lafrech lafrech mentioned this pull request Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants