Fix few things related to query_counter context manager #1871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bagerard
commented
Sep 3, 2018
bagerard
commented
- Improve doc
- Fix the fact that the context was modifying the initial profiling_level in case it was != 0 (Fixes query_counter leaves the profiling_level 0 no matter the initial value of the profiling #1870)
- Ignores 'killcursors' to fix flaky test that were impacted by killcursors queries (Fixes Flaky test in test suite makes CI randomly failing due to query_counter context manager #1869)
bagerard
force-pushed
the
improve_query_counter
branch
from
798d655 to
9a3505c
Compare
Collaborator
|
roar again, style error :) @bagerard |
- Improve doc - Fix the fact that the context was modifying the initial profiling_level in case it was != 0 - Ignores 'killcursors' to fix flaky test that were impacted by killcursors queries (MongoEngine#1869)
bagerard
force-pushed
the
improve_query_counter
branch
from
9a3505c to
8ff8299
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.