Supported updates of an array by negative index #2094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@divomen could you please add a unit test? |
Contributor
Author
|
Ok, will add it |
divomen
force-pushed
the
negative_indexes_in_list
branch
from
ec5a6a5 to
6a4c342
Compare
Member
|
Thanks! Please tag me as the reviewer once done. Feel free to ask for help if you run into any trouble as well! :) |
Member
|
Have you had a chance to look into this @divomen? :) |
Contributor
Author
|
Yes, I hope at end of this week.
…On Mon, Jul 8, 2019 at 3:17 PM Stefan Wójcik ***@***.***> wrote:
Have you had a chance to look into this @divomen
<https://github.com/divomen>? :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2094?email_source=notifications&email_token=AABCRUOR24FHXOZVKDYBAJTP6MV4LA5CNFSM4HY76GH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZM4X4Q#issuecomment-509201394>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABCRUOGIG4F4M4WRTJEA3TP6MV4LANCNFSM4HY76GHQ>
.
--
/dim
|
Collaborator
|
@wojcikstefan, could you review this when you have a chance? I just added a simple test case inspired by the author's gist (all credits goes to @divomen) |
Contributor
Author
|
It looks great, thank you
…On Wed, Jul 24, 2019 at 10:39 PM Bastien Gérard ***@***.***> wrote:
@wojcikstefan <https://github.com/wojcikstefan>, could you review this
when you have a chance? I just added a simple test case inspired by the
author's gist
<https://gist.github.com/divomen/49e6b31c83b3396faf3be381be2ff893> (all
credits goes to @divomen <https://github.com/divomen>)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2094?email_source=notifications&email_token=AABCRUOMNNR63YKD5XCS7Y3QBCVXHA5CNFSM4HY76GH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2XMSLA#issuecomment-514771244>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABCRULKHQRRCLW77QFDTFLQBCVXHANCNFSM4HY76GHQ>
.
--
/dim
|
Collaborator
|
kind reminder @wojcikstefan, could you check this when you have a chance :) ? |
…tive_indexes_in_list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New pull request instead of #2092
It's based on master.