Custom ID field test improvements #2095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This more closely aligns with the rule that a single tests should test one thing and one thing only. Previous code tested like 4 different things in a single test and was hard to follow.
wojcikstefan
force-pushed
the
custom-id-field-test-improvements
branch
from
af5bcc3 to
5385c49
Compare
wojcikstefan
force-pushed
the
custom-id-field-test-improvements
branch
from
032942a to
13dc931
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits up custom PK field tests. The new approach more closely aligns with the rule that a single tests should test one thing and one thing only. Previous code tested like 4 different things in a
single test and was hard to follow.