Mention DynamicEmbeddedDocument in usage docs.#2536
Merged
bagerard merged 1 commit intoMongoEngine:masterfrom Jul 2, 2021
ottj3:patch-1
Merged
Mention DynamicEmbeddedDocument in usage docs.#2536bagerard merged 1 commit intoMongoEngine:masterfrom ottj3:patch-1
bagerard merged 1 commit intoMongoEngine:masterfrom
ottj3:patch-1
Conversation
bagerard
approved these changes
Jul 2, 2021
Collaborator
bagerard
left a comment
bagerard
left a comment
There was a problem hiding this comment.
Lookgs good, thanks for the contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Though hidden away in the generated api reference, DynamicEmbeddedDocument isn't mentioned at all in the usage sections, and web searches for terms like "dynamic embeddeddocument [mongoengine]" bring up stackoverflow posts such as this one where the answer actually links to the dynamic documents section of the docs...but doesn't actually mention that DynamicEmbeddedDocument exists. This small change should hopefully improve discoverability.