Fix embedded instance deepcopy#2545
Merged
bagerard merged 4 commits intoMongoEngine:masterfrom Aug 7, 2021
Merged
Conversation
bagerard
force-pushed
the
fix_embedded_instance_deepcopy
branch
from
71d85af to
66978ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on #2495 , it's a slightly modified version
I decided to set
_instanceto None instead of its initial value because I don't see why we would want the deepcopy of an EmbeddedDoc to point to the initial parent Document and it may create some weird bugs.I believe it's safer that the deepcopied instance isn't attached to any parent Document, like it is when it is instantiated