Skip to content

Added Brazilian Portuguese Translation#254

Closed
jpereira wants to merge 1 commit into
MonitorControl:masterfrom
jpereira:pt-BR
Closed

Added Brazilian Portuguese Translation#254
jpereira wants to merge 1 commit into
MonitorControl:masterfrom
jpereira:pt-BR

Conversation

@jpereira
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@felipemlemos felipemlemos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@the0neyouseek the0neyouseek added the translation Issue is for app/documentation i18n label Jul 10, 2020
@JoniVR
Copy link
Copy Markdown
Member

JoniVR commented Aug 2, 2020

I think you missed one or two strings, everything else looks good! Thanks!

image

I also added a commit to fix a truncation issue, this way the user can resize the table columns themselves if something is getting truncated.

@jpereira
Copy link
Copy Markdown
Author

jpereira commented Aug 3, 2020

I didn't find that point. even because the next "Advanced" is already translated.

e.g:

[jpereira@sugarloaf:MonitorControl.git]$ grep Advanced -A1 -r $(find MonitorControl -iname pt-BR*)
MonitorControl/UI/pt-BR.lproj/Main.strings:/* Class = "NSTextFieldCell"; title = "Advanced"; ObjectID = "5wk-Dy-0fG"; */
MonitorControl/UI/pt-BR.lproj/Main.strings-"5wk-Dy-0fG.title" = "Avançado";
[jpereira@sugarloaf:MonitorControl.git]$

Copy link
Copy Markdown

@h3nnn4n h3nnn4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I was passing by and saw this PR. As a native speaker I thought I could help pointing a few little things 😉

Also, nice work. Always good to see things being translated to our native languages. It makes technology so much more accessible.

Comment thread MonitorControl/Support/pt-BR.lproj/Localizable.strings Outdated
Comment thread MonitorControl/UI/pt-BR.lproj/Main.strings Outdated
Comment thread MonitorControl/UI/pt-BR.lproj/Main.strings Outdated
@JoniVR
Copy link
Copy Markdown
Member

JoniVR commented Oct 18, 2020

@jpereira I have updated master with a fix for the "Advanced" string not being found, if you'd be willing to update everything one more time, it should probably be solved now 🙂

@jpereira
Copy link
Copy Markdown
Author

Hi @JoniVR , for sure. I updated the branch right now. thanks, @h3nnn4n for the review.

@JoniVR
Copy link
Copy Markdown
Member

JoniVR commented Nov 22, 2020

Hi @jpereira, thanks for updating so swiftly, I noticed you were still missing some translations. I should probably have mentioned that it would be easier to just merge in master.

I just did it for you and resolved the conflicts, but I can't seem to push them to this Pull Request, do you have the Allow edits from maintainers toggle on the right side checked?

image

If you'd rather do it yourself, here's the steps you need to take:

  1. Merge master branch into this PR branch.
  2. run bartycrouch update inside the root directory of this project.
  3. Update the missing translations.

@jpereira
Copy link
Copy Markdown
Author

It is already enabled.
image

@jpereira
Copy link
Copy Markdown
Author

@JoniVR I updated as you suggested.

@h3nnn4n
Copy link
Copy Markdown

h3nnn4n commented Mar 22, 2021

Bump?

@jpereira jpereira closed this Jul 20, 2021
@jpereira jpereira deleted the pt-BR branch July 20, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation Issue is for app/documentation i18n

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants