Hash req #22
Merged
Hash req #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three patches.
First of all, there is no Digest::SHA1 package in the Ubuntu repositories. Digest::SHA is slower than Digest::SHA1, but it's easy to use with Ubuntu Linux. This patch adds fall back to Digest::SHA.
Also there were a bug that treated an false favicon attribute as a favicon.ico path, instead of disabling favicon. The second commit fixes this issue.
The last one allows using pre-bounded sockets to create an server object. it's useful for code reloading.