Conversation
…sion to v2.0.0-alpha.7
There was a problem hiding this comment.
Pull request overview
This PR upgrades the core Ferret engine dependency to v2.0.0-alpha.7 and aligns the builtin runtime with the updated Ferret session parameter API by removing intermediate parameter parsing.
Changes:
- Bump
github.com/MontFerret/ferret/v2fromv2.0.0-alpha.5tov2.0.0-alpha.7. - Simplify builtin runtime execution by passing
paramsdirectly toferret.WithSessionParamsin bothRunandRunArtifact. - Remove the now-unused Ferret
pkg/runtimeimport from the builtin runtime.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/runtime/builtin.go | Removes runtime.NewParamsFrom usage and passes params directly into Ferret session options. |
| go.mod | Updates Ferret dependency version to v2.0.0-alpha.7. |
| go.sum | Updates checksums for the new Ferret version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| func (rt *Builtin) Run(ctx context.Context, query *source.Source, params map[string]any) (io.ReadCloser, error) { | ||
| parsedParams, err := runtime.NewParamsFrom(params) | ||
|
|
||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| res, err := rt.engine.Run(ctx, query, ferret.WithSessionParams(parsedParams)) | ||
| res, err := rt.engine.Run(ctx, query, ferret.WithSessionParams(params)) | ||
|
|
There was a problem hiding this comment.
The behavior of passing params directly into ferret.WithSessionParams is now relied on for non-artifact execution as well, but existing tests only appear to cover the compiled-artifact path with params. Please add a test that runs a source query with params (e.g., RETURN @value) to ensure the updated Ferret version correctly consumes map[string]any session params in Run too.
This pull request updates the Ferret engine dependency to a newer alpha release and simplifies how query parameters are passed to the engine in the
Builtinruntime. The main focus is on removing unnecessary parameter parsing, leveraging improvements in the updated Ferret library.Dependency update:
github.com/MontFerret/ferret/v2dependency fromv2.0.0-alpha.5tov2.0.0-alpha.7ingo.mod.Parameter handling simplification:
runtime.NewParamsFromto parse parameters in bothRunandRunArtifactmethods inpkg/runtime/builtin.go, passing theparamsmap directly toferret.WithSessionParams. This makes the code simpler and relies on the updated Ferret API. [1] [2] [3]Code cleanup:
github.com/MontFerret/ferret/v2/pkg/runtimefrompkg/runtime/builtin.go.