Conversation
Created a few key variables, functions without knowledge of exact specifications of robot
rafaelbaird
requested changes
Jan 19, 2026
Contributor
rafaelbaird
left a comment
rafaelbaird
left a comment
There was a problem hiding this comment.
Looks really good! A few minor tweaks, then you'll add SydID, re-request my review, and I'll be able to merge into the main branch after that. The flywheel isn't worth testing in sim, so after I merge into main (hopefully tomorrow or Wednesday), you'll be able to move on to other subsystems because we now have a clearer concept of what the robot will look like.
Added SysID routine as well as fixed the comments Rafael left after a pull request on 1/19 (added atSetpoint(), etc.)
Added flywheel real and sim objects in the robot container
Member
|
This was squashed & merged by Rafael. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wheel