Fix: Make NavigableSetterDecorator application deactivatable#30
Merged
luepges merged 5 commits intoMontiCore:devfrom May 10, 2025
Conversation
luepges
approved these changes
May 9, 2025
Contributor
Author
|
@luepges can you merge? I do not have the rights 😇 |
Contributor
|
(Sorry in case you receive a bunch of action mails, I'm just using your PR to finally add the CI for PRs via forks) |
Contributor
Author
|
No problem and thank you! |
|
✔️ Changes pass the MontiVerse
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

In contrast to other decorations added by cd2java.init.CD2Pojo.ftl ( GetterDecorator, SetterDecorator, etc.), NavigableSetterDecorator can not be deactivated via custom configuration templates, as it misses the check whether it should be applied.
This leads to an especially bizarre situation when attempting to deactivate both
SetterDecoratorandNavigableSetterDecorator: NavigableSetterDecorator errornously wants to execute and requests the decorator data that it expects to be left behind by SetterDecorator. As the latter did not run, as it was deactivated, a null value is produced and, in consequence, a NullPointerException is thrown.This merge request adds the check for applicability to the NavigableSetterDecorator.
The inserted check is the same as, for example, in SetterDecorator: