P4 experimental#224
Merged
troyhacks merged 41 commits intoMoonModules:P4_experimentalfrom Feb 17, 2025
Merged
Conversation
Fixes for ES8311 auto level control
…updating() Another instance of the "if (strip.isupdating()) return;" problem that we inherited from upstream 🙄
* make XY() and _setPixelColorXY_raw() const (minor speedup) * segment is a struct not a class: friend class Segment --> friend struct Segment * fix missing braces around two macros * use non-throwing "new" where possible * improve robustness of transition code
Update readme.md for rgb-rotary-encoder usermod
Add correct pin availability for ESP32 Mini modules
this complements the previous commit
- helps to stabilize power on the LEDs before sending data
* switch on relay _after_ the current leds transmission is complete.
when the user wants less than 42 fps, respect this limit during transitions.
... allows to start effects a bit aerlier. Enabled by default on -S3. for your own builds, add `-DWLEDMM_NO_SERIAL_WAIT` to build_flags.
* wait until strip.service() is done * blank strip * wait until all LEDs are updated * load new preset
MM builds are still using the standard arduino platform - we'll "flip the switch" later
support up to 56 GPIO pins (0 thru 55)
* use a more meaningful max universes limit of 112 (safe up to 128x128 pixels) * accept more universes, but only track sequences for the configures max universes * made e131LastSequenceNumber[] local (its only used in e131.cpp)
* move "progress()" into FX.h so the compiler can inline it * removed redundant checks in currentBri()
Seems like a 10 microsecond delay on boards like the ESP32-P4 may not be enough, causing some issues with UDP audio sync being delayed or appearing "buffered". Oddly 10 microseconds was fine with the ESP32 and ESP32-S3, so it may also be an underlying IDF v5.3 change. Practically, 10 microseconds or 100 microseconds isn't a real difference when we're dealing in frames per second.
* isValid() -> isOk() * removed unneeded "lastBus != nullptr" checks * re-enable lastBus optimization in getPixelColor() and getPixelColorRestored() * remove duplicate checks for _valid== true from busses (already done at BusManager level)
* use bitmask operations in getBitFromArray, setBitInArray * make currentBri "const"
fix for a corner case that might lead to unexpected math overflow
* moving color_blend, color_add, and color_fade to a seperate file, to allow the compiler to inline the functions. * inlining slightly increases firmware size - original non-inline functions get used on 8266, or when WLEDMM_SAVE_FLASH is defined.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest and greatest. Now with local LED support!