bugfix for very low brightness in PS FX

[DedeHai]

using my old PS MM branch for this PR, a squash merge may be best.

Summary by CodeRabbit

• Refactor
  • Improved color rendering in particle system effects for more consistent brightness and blending.

[coderabbitai]

Walkthrough

The update refactors calls to the ColorFromPalette function within the render() methods of ParticleSystem2D and ParticleSystem1D. It now explicitly specifies the brightness as 255 and separates the blend mode argument, clarifying parameter usage. No public interfaces or control flow are changed.

Changes

File(s)	Change Summary
wled00/FXparticleSystem.cpp	Refactored ColorFromPalette calls in ParticleSystem2D and ParticleSystem1D to use explicit brightness and blend mode parameters.

Poem

In palettes bright, the colors blend,
With clarity, our calls we send.
Full brightness now, no guess or fuss,
The particles shine, just right for us!
A hop, a skip, a code refined,
In every hue, perfection lined.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

wled00/FXparticleSystem.cpp (1)

593-594: Removed double-dimming – implementation looks correct

Passing 255 as the palette-brightness ensures the hue lookup is un-attenuated; the actual fading is still handled by the separate brightness scalar fed into renderParticle().
This cleanly fixes the “very low brightness” issue without side-effects.

Minor nit: consider using a named constant (UINT8_MAX or 0xFF) to document intent and avoid a magic number.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b63e72e and 0ea505e.

📒 Files selected for processing (1)

• wled00/FXparticleSystem.cpp (2 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: DedeHai
PR: MoonModules/WLED-MM#237
File: wled00/FXparticleSystem.cpp:241-248
Timestamp: 2025-05-04T10:31:58.857Z
Learning: In the particle system (FXparticleSystem.cpp), calling `setParticleSize()` inside the particle update loop is intentional despite potential performance implications. This design decision prioritizes code reuse and maintainability over performance optimization.

wled00/FXparticleSystem.cpp (3)

Learnt from: DedeHai
PR: MoonModules/WLED-MM#237
File: wled00/FXparticleSystem.cpp:241-248
Timestamp: 2025-05-04T10:31:58.857Z
Learning: In the particle system (FXparticleSystem.cpp), calling `setParticleSize()` inside the particle update loop is intentional despite potential performance implications. This design decision prioritizes code reuse and maintainability over performance optimization.

Learnt from: DedeHai
PR: MoonModules/WLED-MM#237
File: wled00/FXparticleSystem.cpp:678-743
Timestamp: 2025-05-04T10:32:30.457Z
Learning: In the Particle System implementation for WLED, stack allocation is preferred over heap allocation for temporary rendering buffers because there's enough stack memory available and heap allocations can cause memory fragmentation.

Learnt from: netmindz
PR: MoonModules/WLED-MM#248
File: platformio.ini:1613-1613
Timestamp: 2025-07-02T23:22:57.175Z
Learning: In WLED platformio.ini, the particle system disable flags (WLED_DISABLE_PARTICLESYSTEM1D and WLED_DISABLE_PARTICLESYSTEM2D) are intentionally varied across different build environments based on platform memory constraints. More memory-limited platforms (like ESP8266, ESP32-C3, ESP32-S2) disable both 1D and 2D particle systems, while platforms with more available memory (like esp32_4MB_V4_S with 4MB flash) may only disable the 1D version to preserve flash space while keeping 2D functionality available.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)

• GitHub Check: Builds (esp32S3_16MB_PSRAM_M_HUB75)
• GitHub Check: Builds (esp32s2_PSRAM_M)
• GitHub Check: Builds (adafruit_matrixportal_esp32s3_tinyUF2)
• GitHub Check: Builds (esp8266_4MB_M)
• GitHub Check: Builds (esp8266_2MB_S)
• GitHub Check: Builds (athom_music_esp32_4MB_M)
• GitHub Check: Builds (esp8266_4MB_S)
• GitHub Check: Builds (esp32c3mini_dio_4MB_M)
• GitHub Check: Builds (esp8266pro_16MB_M)
• GitHub Check: Builds (esp32c3dev_2MB_M)
• GitHub Check: Builds (esp32S3_8MB_S)
• GitHub Check: Builds (esp32c3dev_4MB_M)
• GitHub Check: Builds (esp32s2_PSRAM_S)
• GitHub Check: Builds (esp32S3_8MB_PSRAM_M)
• GitHub Check: Builds (esp32_4MB_V4_S)
• GitHub Check: Builds (esp32_16MB_V4_M)
• GitHub Check: Builds (esp32S3_4MB_S)
• GitHub Check: Builds (esp32_16MB_V4_S)
• GitHub Check: Builds (esp32_4MB_V4_HUB75_forum)
• GitHub Check: Builds (esp32_4MB_PSRAM_S)

🔇 Additional comments (1)

wled00/FXparticleSystem.cpp (1)

1455-1456: Same brightness fix applied to 1-D renderer – consistent with 2-D path

The change mirrors the 2-D fix and removes the unintended additional attenuation. Consistency across renderers is maintained. 👍