chore: move coding guidelines from .github to docs/#358
Conversation
…nces Agent-Logs-Url: https://github.com/MoonModules/WLED-MM/sessions/33ac383b-b8e4-4e0d-8dee-3bd94b4e41b6 Co-authored-by: softhack007 <91616163+softhack007@users.noreply.github.com>
Agent-Logs-Url: https://github.com/MoonModules/WLED-MM/sessions/234d8f8a-1b80-4373-89b0-9d9675701ebc Co-authored-by: softhack007 <91616163+softhack007@users.noreply.github.com>
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR relocates instruction file references from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai this PR moves our coding guides into a new folder docs/. Please very that the changes in .coderabbit.yaml to ensure that files in the new location will be used in your reviews. .github/copilot-instructions.md stays into old location, so its mandatory to read for all AI tasks. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chainLet me inspect the actual files to verify everything is correct. 🏁 Script executed: Length of output: 6267
✅
|
| What | Old path | New path | Status |
|---|---|---|---|
| C++ conventions | .github/cpp.instructions.md |
docs/cpp.instructions.md |
✅ Updated |
| Web UI conventions | .github/web.instructions.md |
docs/web.instructions.md |
✅ Updated |
| CI/CD conventions | .github/cicd.instructions.md |
docs/cicd.instructions.md |
✅ Updated |
| ESP-IDF guidelines | .github/esp-idf.instructions.md |
docs/esp-idf.instructions.md |
✅ Updated |
| Path selector for alignment checks | .github/*.instructions.md |
docs/*.instructions.md |
✅ Updated |
| Project overview / general rules | .github/copilot-instructions.md |
.github/copilot-instructions.md |
✅ Intentionally kept in old location |
✅ File presence confirmed
- All 4 instruction files are present in
docs/(cpp,web,cicd,esp-idf) .github/copilot-instructions.mdremains in.github/as intended- The
.github/workflows/*.{yml,yaml}path selector is unaffected (correctly still points to.github/workflows/)
No stale .github/*.instructions.md references remain in .coderabbit.yaml.
⚠️ One item to confirm
.github/agent-build.instructions.md is still present in .github/ but is not referenced in .coderabbit.yaml. Was this file intentionally left behind (e.g., it's a GitHub Copilot agent instruction, not a CodeRabbit review guideline), or should it also be moved to docs/ and referenced?
🧠 Learnings used
Learnt from: softhack007
Repo: MoonModules/WLED-MM PR: 0
File: :0-0
Timestamp: 2026-04-04T00:29:49.113Z
Learning: In MoonModules/WLED-MM, function-level doc comment blocks (e.g. /* ***** */ style headers) are NOT required during code reviews, especially not for previously existing functions. Do not flag missing function-level comments as review issues in this repository.
Learnt from: softhack007
Repo: MoonModules/WLED-MM PR: 0
File: :0-0
Timestamp: 2026-04-04T14:32:02.598Z
Learning: In MoonModules/WLED-MM, clang-format is intentionally NOT enforced via CI or .clang-format config because it would cause merge conflicts when cherry-picking features from upstream WLED (which uses different formatting). Instead, "soft" formatting rules are documented in .github/cpp.instructions.md. Do not recommend adding clang-format to CI as a follow-up to missing automated enforcement — the decision is deliberate.
@coderabbitai Yes this was intentionally - the file is only meant for copilot agent tasks. |
|
Tip For best results, initiate chat on the files or code changes.
With that confirmed, the PR looks good — all coding guideline files have been correctly relocated to ✏️ Learnings added
🧠 Learnings used |
Updated links in CONTRIBUTING.md to point to the correct documentation directory.
Summary by CodeRabbit