added series sort option for date content last added, and more localization stuff#324
Conversation
broken-droid
force-pushed
the
feature/sort-option-and-more-localization
branch
from
8fae782 to
4485f16
Compare
| add(SortOption(R.string.lbl_date_added, ItemSortBy.DATE_CREATED, SortOrder.DESCENDING)) | ||
| } | ||
| if (folder?.collectionType == CollectionType.TVSHOWS) { | ||
| add(SortOption(R.string.lbl_date_episode_added, ItemSortBy.DATE_LAST_CONTENT_ADDED, SortOrder.DESCENDING)) |
There was a problem hiding this comment.
Why not add this under line 114?
There was a problem hiding this comment.
I think I was focused on adding one and then then threw the other in there, I can change that
| val resumeTime = item.userData?.playbackPositionTicks?.let { formatDuration(it) } ?: "" | ||
| DetailActionButton( | ||
| label = "Resume", | ||
| label = stringResource(R.string.lbl_resume_from), |
There was a problem hiding this comment.
| label = stringResource(R.string.lbl_resume_from), | |
| label = stringResource(R.string.lbl_resume_from, resumeTime), |
The string is defined as "Resume from %1$s" but here it's used as a plain label without passing the time position. This will render as "Resume from %1$s" literally on screen. This was it'll return back Resume from 1h 23m
| item { | ||
| Text( | ||
| text = "Tracks", | ||
| text = stringResource(R.string.lbl_track), |
There was a problem hiding this comment.
we need a new lbl_tracks for multiple since now lbl_track is being used for singular and plural
|
I really appreciate your contributions by the way |
|
I can't build currently, so I can't try anything out. This is left over from my merge attempt after emby got added. Not sure how you generated the emby sdk. |
|
pull latest and you'll have the fix |
…alization changes modified strings.xml and variants - new strings for eng/fr/de/es modified ItemDetailsFragment.kt - convert more strings to localized - formatDuration uses a localized formatted string - getEndsAt uses the system time format instead of forcing am/pm or 12/24 hr clock for the end time - PersonalDetailsContent uses localized datetime format modified LeftSidebarNavigation.kt - use localized shuffle/settings string - use stringResource instead of context.getString in a few places modified MainToolbar.kt - use localized shuffle/settings string
added en/de/fr/es versions changed lbl_track to 'lbl_tracks' changed 'Resume from' label to pass in argument
broken-droid
force-pushed
the
feature/sort-option-and-more-localization
branch
from
4485f16 to
461dc3c
Compare
There's a reference to emby-client that android studio can't find, and I don't know the parameters or generator used to get it to match. Unless I'm missing something. |
|
Odd, I had someone pull latest after this commit and it fixed it. I'll take a look |
please pull latest, added it as emby-client JAR |
2 participants
Mostly localization stuff, but added in an option for #321
Pull Request
Summary
Added a sort option for tvshows, date_content_last added
Added some more translated strings
Changed more details/nav bar strings to use localized ones
Changed a few date related things to use system format instead of forcing am/pm 12/24hr
Related Issues
#321
Closes #
[Feature] Sort TV shows by last episode added #321
Fixes #
Related to #
Type of Change
Changes Made
modified LibraryBrowseViewmodel.kt
modified strings.xml and variants
modified ItemDetailsFragment.kt
modified LeftSidebarNavigation.kt
modified MainToolbar.kt
Testing
Test Steps
Screenshots (if applicable)
Checklist