Skip to content

Fix Show Display in Home Screen Collections#374

Merged
RadicalMuffinMan merged 1 commit into
Moonfin-Client:mainfrom
mattsigal:feature/fix-series-display
Jun 6, 2026
Merged

Fix Show Display in Home Screen Collections#374
RadicalMuffinMan merged 1 commit into
Moonfin-Client:mainfrom
mattsigal:feature/fix-series-display

Conversation

@mattsigal

@mattsigal mattsigal commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Collections Home Row Display & Sorting Fix

Summary

Modifies the collection home row loading logic to query items non-recursively. This prevents shows in collections from rendering as a long list of individual season and episode cards on the home screen, while still naturally displaying specific seasons or episodes if they are ever directly added to a collection.

Additionally, this PR updates the sorting logic to respect the user's configured collection sort order settings, falling back to UserPreferences instead of forcing a hardcoded sort order.

Related Issues

  • Closes issue 372

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

  • Changed recursive: true to recursive: false in loadCollectionRow (row_data_source.dart).
  • Updated loadCollectionRow to use the passed sortBy and sortOrder parameters (from UserPreferences) instead of hardcoding them.

Platform

  • Android
  • iOS
  • macOS
  • Windows
  • Linux
  • All / Shared code

Testing

  • Tested on physical device
  • Manual testing completed

Test Steps

  1. Add a collection containing shows to the Home Screen Sections (e.g. via Personalization -> Home Screen).
  2. Verify that the collection row on the home page displays only the main show poster/thumbnail and links to the show details page.
  3. Verify that items in the collection row are sorted by the user's configured preference (e.g., Release Date, Sort Name).
  4. Verify that if a specific season/episode is added to a collection, it is still displayed at its respective level.

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

@mattsigal mattsigal force-pushed the feature/fix-series-display branch from 76369fb to e401827 Compare June 6, 2026 00:39
@RadicalMuffinMan RadicalMuffinMan merged commit 60abf20 into Moonfin-Client:main Jun 6, 2026
5 checks passed
mattsigal added a commit to mattsigal/moonfin-core that referenced this pull request Jun 6, 2026
- Avoids expanding shows into individual episodes by disabling recursive playlist items fetching, aligning with PR Moonfin-Client#374.
- Fixes loadPlaylistRow and loadMore pagination logic for individual playlists to use recursive: false and correctly query playlist items.
RadicalMuffinMan pushed a commit that referenced this pull request Jun 6, 2026
* Add Playlist home screen display and sorting options to mirror other customizable options

* Set recursive to false in playlists loading and fix paging
- Avoids expanding shows into individual episodes by disabling recursive playlist items fetching, aligning with PR #374.
- Fixes loadPlaylistRow and loadMore pagination logic for individual playlists to use recursive: false and correctly query playlist items.

---------

Co-authored-by: mattsigal <mattsigal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants