Merged
Conversation
- verify-otel shared trace IDs: assert >= 1 (not 5) and check for zero orphaned provider trace IDs. Testnet runs as a single unified trace, unlike Docker tests which create multiple traces per bundle. - testnet-verify: add 60s ingestion wait before OTEL verification to allow Grafana Cloud Tempo to ingest the final spans.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes for testnet OTEL trace verification:
verify-otel shared trace IDs: Changed from
>= 5to>= 1shared trace IDs, and added a check for zero orphaned provider trace IDs. Testnet runs produce a single unified distributed trace (1 trace ID shared across SDK + provider), unlike Docker tests which create multiple traces per bundle.testnet-verify ingestion wait: Added 60s wait before OTEL verification in the lifecycle script. Without this, the final spans (e.g., withdraw) haven't been flushed to Grafana Cloud Tempo when verification starts.
What's NOT affected
e2e/verify-otel.ts) use Jaeger with a separate code path — unaffected by these changes../test.sh otel) verified passing after change.Test plan