fix: use correct type for _current_global_parameter_metas #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a type assignment issue by properly instantiating MemoryBufferMetaList objects instead of directly assigning metas_buckets to the _current_global_parameter_metas dictionary.
- Replaces direct assignment with proper
MemoryBufferMetaListconstructor call - Ensures type consistency by extracting required fields from
metas_buckets
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
weixiao-huang
force-pushed
the
fix/meta-list
branch
from
d3d470a to
8b12dcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.