feat(vis): add session dir actions and Windows open-in support by RealKai42 · Pull Request #1416 · MoonshotAI/kimi-cli

RealKai42 · 2026-03-12T08:01:57Z

Summary

add Open Dir and Copy DIR actions to the Kimi vis session page
expose session_dir in the vis API and wire /api/open-in into the vis server
make Copy DIR copy the raw session directory path
extend open-in to support Windows in addition to macOS
update the vis Vite proxy so open-in works in local dev
add coverage for vis session metadata and Windows open-in behavior

Checklist

I have read the CONTRIBUTING document.
I have linked the related issue, if any.
I have added tests that prove my fix is effective or that my feature works.
I have run make gen-changelog to update the changelog.
I have run make gen-docs to update the user documentation.

… compatibility

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8ff47633ed

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-12T08:06:32Z

src/kimi_cli/vis/app.py


    application.include_router(sessions_router)
    application.include_router(statistics_router)
+    application.include_router(open_in_router)


Protect open-in route before mounting it in vis app

Including open_in_router in the vis server exposes /api/open-in on an app that has permissive CORS and no auth checks, so any web page the user visits can issue cross-origin POSTs to the local vis process and trigger local app launches while it is running. This is a regression in protection for a sensitive endpoint: in the web server, the same router is behind AuthMiddleware and can be disabled via restrict_sensitive_apis, but this mount bypasses those safeguards.

Useful? React with 👍 / 👎.

Copilot

Pull request overview

Adds “open/copy session directory” functionality to the Tracing Visualizer UI by exposing a new /api/open-in endpoint from the vis server and returning the session directory path in the sessions listing, with Windows support and accompanying tests.

Changes:

Broaden Vite dev proxy to forward all /api/* requests (so /api/open-in works in dev).
Return session_dir in vis session listings and surface UI actions to open/copy the directory.
Extend open-in backend API to support Windows + add tests for the new API surface.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
vis/vite.config.ts	Proxy `/api/*` to backend (enables `/api/open-in` during frontend dev).
vis/src/lib/api.ts	Adds `session_dir` to `SessionInfo` and implements `openInPath()` client call.
vis/src/App.tsx	Adds UI actions to open/copy the current session directory; improves title derivation and refresh behavior.
tests/web/test_open_in.py	Verifies Windows command invocation behavior for `open-in`.
tests/vis/test_app.py	Ensures `session_dir` is included in `/api/vis/sessions` and that `/api/open-in` is mounted.
src/kimi_cli/web/api/open_in.py	Adds Windows implementations and broadens platform support beyond macOS.
src/kimi_cli/vis/app.py	Mounts the `open-in` router into the vis FastAPI app.
src/kimi_cli/vis/api/sessions.py	Includes `session_dir` in session scan results.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-12T08:07:14Z

src/kimi_cli/vis/app.py

    application.include_router(sessions_router)
    application.include_router(statistics_router)
+    application.include_router(open_in_router)


Including open_in_router in the vis app exposes a sensitive local-operation endpoint (/api/open-in) without the auth / origin controls used by the main web app (see src/kimi_cli/web/app.py, which gates this behind restrict_sensitive_apis + AuthMiddleware). With the current permissive CORS in vis (allow_origins=['*']), this increases risk of cross-site requests triggering local app launches or probing local filesystem paths. Please gate this route behind a similar "restrict sensitive APIs" flag and/or add request-origin / local-client checks before enabling it.

Copilot · 2026-03-12T08:07:14Z

src/kimi_cli/web/api/open_in.py



+def _open_windows_app(command: str, path: Path) -> None:
+    _run_command(["cmd", "/c", "start", "", command, str(path)])


_open_windows_app uses cmd /c start with command and path passed as separate args. On Windows this runs through cmd.exe parsing, and arguments that don’t contain spaces may not be quoted/escaped (e.g. paths containing &, |, etc.), which can allow command injection if a crafted existing path is provided. Prefer launching the executable directly (e.g. subprocess.Popen([command, str(path)], ...) with appropriate detached creation flags) or ensure the arguments are safely quoted/escaped for cmd regardless of spaces.

Suggested change

_run_command(["cmd", "/c", "start", "", command, str(path)])

# Launch the Windows application directly to avoid cmd.exe parsing

subprocess.Popen([command, str(path)], close_fds=True)

Copilot · 2026-03-12T08:07:14Z

src/kimi_cli/web/api/open_in.py

 @router.post("", summary="Open a path in a local application")
 async def open_in(request: OpenInRequest) -> OpenInResponse:
-    if sys.platform != "darwin":
+    if sys.platform not in {"darwin", "win32"}:
        raise HTTPException(
            status_code=status.HTTP_400_BAD_REQUEST,
-            detail="Open-in is only supported on macOS.",
+            detail="Open-in is only supported on macOS and Windows.",
        )

    path = _resolve_path(request.path)
    is_file = path.is_file()

    try:
-        match request.app:
-            case "finder":
-                if is_file:
-                    # Reveal file in Finder
-                    _run_command(["open", "-R", str(path)])
-                else:
-                    _run_command(["open", str(path)])
-            case "cursor":
-                _open_app("Cursor", path)
-            case "vscode":
-                _open_app("Visual Studio Code", path, fallback="Code")
-            case "antigravity":
-                _open_app("Antigravity", path)
-            case "iterm":
-                # Terminal apps need directory
-                directory = path.parent if is_file else path
-                _open_iterm(directory)
-            case "terminal":
-                directory = path.parent if is_file else path
-                _open_terminal(directory)
-            case _:
-                raise HTTPException(
-                    status_code=status.HTTP_400_BAD_REQUEST,
-                    detail=f"Unsupported app: {request.app}",
-                )
+        if sys.platform == "darwin":
+            _open_in_macos(request, path, is_file=is_file)
+        else:
+            _open_in_windows(request, path, is_file=is_file)


open_in is declared async but calls subprocess.run(...) (via _run_command) directly. This blocks the event loop while the OS command executes, which can stall other requests on the vis server. Consider running the open operation in a worker thread (e.g. await asyncio.to_thread(...)) or otherwise offloading the blocking call so the FastAPI app stays responsive.

devin-ai-integration

Devin Review found 1 potential issue.

View 5 additional findings in Devin Review.

devin-ai-integration · 2026-03-12T08:08:02Z

src/kimi_cli/web/api/open_in.py

+def _open_windows_explorer(path: Path, *, is_file: bool) -> None:
+    if is_file:
+        _run_command(["explorer", f"/select,{path}"])
+    else:
+        _run_command(["explorer", str(path)])


🔴 explorer.exe returns non-zero exit code on success, causing false error with check=True

_open_windows_explorer invokes explorer.exe directly via _run_command (src/kimi_cli/web/api/open_in.py:50-56), which calls subprocess.run(..., check=True). On Windows, explorer.exe is well-known for returning exit code 1 even when the operation succeeds (because it delegates to the already-running Explorer shell process via COM). Since check=True raises CalledProcessError on any non-zero exit code, the call at line 99 or 101 will raise an exception in typical Windows desktop usage. The outer exception handler in open_in() at src/kimi_cli/web/api/open_in.py:179-185 then converts this to an HTTP 500 error—even though the Explorer window actually opened correctly. The user sees a "Failed to open session directory" error alert in the UI despite the folder being shown. Other Windows functions (_open_windows_app, _open_windows_terminal) avoid this by going through cmd /c start, which returns 0 immediately.

Suggested change

def _open_windows_explorer(path: Path, *, is_file: bool) -> None:

if is_file:

_run_command(["explorer", f"/select,{path}"])

else:

_run_command(["explorer", str(path)])

def _open_windows_explorer(path: Path, *, is_file: bool) -> None:

if is_file:

subprocess.Popen(["explorer", f"/select,{path}"])

else:

subprocess.Popen(["explorer", str(path)])

Was this helpful? React with 👍 or 👎 to provide feedback.

…ccess on macOS and Windows

…ectory actions

…ocess handling

Signed-off-by: Kai <me@kaiyi.cool>

feat: add support for opening session directories and enhance Windows…

8ff4763

… compatibility

Copilot AI review requested due to automatic review settings March 12, 2026 08:01

Copilot started reviewing on behalf of RealKai42 March 12, 2026 08:02 View session

chatgpt-codex-connector bot reviewed Mar 12, 2026

View reviewed changes

Copilot AI reviewed Mar 12, 2026

View reviewed changes

devin-ai-integration bot reviewed Mar 12, 2026

View reviewed changes

RealKai42 added 4 commits March 12, 2026 16:10

feat(vis): add session directory shortcuts in kimi vis for easier a…

88fae93

…ccess on macOS and Windows

feat(vis): add system capabilities API and integrate into session dir…

19cadd2

…ectory actions

feat(api): enhance open-in functionality with async support and subpr…

92bf3a5

…ocess handling

Merge branch 'main' into kaiyi/session-open-copy-dir

ea9ee2d

Signed-off-by: Kai <me@kaiyi.cool>

RealKai42 merged commit 4776638 into main Mar 12, 2026
20 checks passed

RealKai42 deleted the kaiyi/session-open-copy-dir branch March 12, 2026 08:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(vis): add session dir actions and Windows open-in support#1416

feat(vis): add session dir actions and Windows open-in support#1416
RealKai42 merged 5 commits intomainfrom
kaiyi/session-open-copy-dir

RealKai42 commented Mar 12, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 12, 2026

Uh oh!

Copilot AI Mar 12, 2026

Uh oh!

Copilot AI Mar 12, 2026

Uh oh!

devin-ai-integration bot left a comment

Uh oh!

devin-ai-integration bot Mar 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants



		def _open_windows_app(command: str, path: Path) -> None:
		_run_command(["cmd", "/c", "start", "", command, str(path)])

	_run_command(["cmd", "/c", "start", "", command, str(path)])
	# Launch the Windows application directly to avoid cmd.exe parsing
	subprocess.Popen([command, str(path)], close_fds=True)

Conversation

RealKai42 commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration bot Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

RealKai42 commented Mar 12, 2026 •

edited

Loading