fix: update upgrade command in toast notifications for consistency#1418
fix: update upgrade command in toast notifications for consistency#1418
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR centralizes the “upgrade” command text used in shell UI notifications so toast and welcome messages stay consistent and can be adjusted in one place.
Changes:
- Introduces a shared
UPGRADE_COMMANDconstant for upgrade messaging. - Updates auto-update toast notification to reference the shared constant.
- Updates welcome banner “new version available” message to reference the shared constant.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/kimi_cli/ui/shell/update.py |
Adds UPGRADE_COMMAND constant to centralize upgrade instruction text. |
src/kimi_cli/ui/shell/__init__.py |
Uses UPGRADE_COMMAND in toast + welcome info to keep messaging consistent. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| from kimi_cli.soul import LLMNotSet, LLMNotSupported, MaxStepsReached, RunCancelled, Soul, run_soul | ||
| from kimi_cli.soul.kimisoul import KimiSoul | ||
| from kimi_cli.ui.shell import update as _update_mod |
There was a problem hiding this comment.
from kimi_cli.ui.shell import update as _update_mod imports the kimi_cli.ui.shell package while its __init__.py is still executing, which is harder to reason about and can create subtle import-order issues. Prefer importing the submodule directly (e.g., import kimi_cli.ui.shell.update as _update_mod or a relative from . import update as _update_mod).
| from kimi_cli.ui.shell import update as _update_mod | |
| from . import update as _update_mod |
Description
Checklist
make gen-changelogto update the changelog.make gen-docsto update the user documentation.