Conversation
Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
stdrc
changed the title
Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the markdown rendering and UI visualization system by removing the markdown toggle feature and consolidating visualization logic. The key changes include:
- Replaced Rich's built-in markdown renderer with a custom implementation to support character-based wrapping for better terminal width handling
- Consolidated step visualization logic by removing the old
liveview.pymodule and integrating its functionality directly intovisualize.py - Renamed
extract_subtitletoextract_key_argumentfor better clarity - Removed the
--markdown/--no-markdownCLI option since markdown rendering is now always enabled - Updated tool result display to use the
brieffield instead ofoutput
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/kimi_cli/utils/rich/markdown.py | Added custom markdown renderer forked from Rich library with modifications for character-based wrapping |
| src/kimi_cli/utils/rich/init.py | Added global Rich configuration to enable character-based text wrapping |
| src/kimi_cli/utils/rich/markdown_sample.md | Added comprehensive markdown test document |
| src/kimi_cli/utils/rich/markdown_sample_short.md | Added minimal markdown test document |
| src/kimi_cli/ui/shell/visualize.py | Refactored visualization logic into a single _LiveView class, integrating functionality from the removed liveview.py |
| src/kimi_cli/ui/shell/liveview.py | Removed entire file, functionality moved to visualize.py |
| src/kimi_cli/ui/shell/init.py | Removed markdown parameter from ShellApp initialization |
| src/kimi_cli/ui/acp/init.py | Updated to use renamed extract_key_argument function |
| src/kimi_cli/tools/init.py | Renamed extract_subtitle to extract_key_argument and simplified SetTodoList handling |
| src/kimi_cli/tools/todo/init.py | Updated to return brief field instead of output |
| src/kimi_cli/cli.py | Removed --markdown/--no-markdown CLI option |
| src/kimi_cli/app.py | Removed markdown parameter from run_shell_mode |
| pyrightconfig.json | Updated type checking configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.