fix(file_filter): add explicit utf-8 encoding to subprocess calls (#1866) #1886
Open
gstggsstt wants to merge 1 commit intoMoonshotAI:mainfrom
Open
fix(file_filter): add explicit utf-8 encoding to subprocess calls (#1866) #1886gstggsstt wants to merge 1 commit intoMoonshotAI:mainfrom
gstggsstt wants to merge 1 commit intoMoonshotAI:mainfrom
Conversation
…onshotAI#1866) Add encoding="utf-8" to all subprocess.run calls in file_filter.py to prevent encoding errors on systems where the default encoding is not UTF-8.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent locale-dependent decoding failures when file_filter.py invokes git by making subprocess.run(..., text=True) decode output explicitly as UTF-8.
Changes:
- Add
encoding="utf-8"tosubprocess.runcalls used bygit_index_mtime,_git_deleted_files, andlist_files_git(tracked + untracked).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…866)
Add encoding="utf-8" to all subprocess.run calls in file_filter.py to prevent encoding errors on systems where the default encoding is not UTF-8.
Related Issue
Resolve #(issue_number)
Description
Checklist
make gen-changelogto update the changelog.make gen-docsto update the user documentation.