fix(acp): list_sessions without cwd returns all sessions#1957
Open
victorhqc wants to merge 5 commits intoMoonshotAI:mainfrom
Open
fix(acp): list_sessions without cwd returns all sessions#1957victorhqc wants to merge 5 commits intoMoonshotAI:mainfrom
victorhqc wants to merge 5 commits intoMoonshotAI:mainfrom
Conversation
Add Session.list_all() support to ACPServer so list_sessions with no cwd returns sessions from all work directories. Add test for this behavior.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
#1956
Resolve #1956
Description
Problem
When an ACP client called
list_sessionswithout acwdargument, the server returned an empty list. This broke session history in editors like Zed.The ACP protocol says
cwdis optional. But kimi-cli treated it as required. Whencwdwas missing, the server gave up and returned[].Fix
cwdis provided, behavior is the same as before.cwdis missing, the server now returns all sessions across all work directories.Also added a test to catch this in the future.
Before (in Zed)
After (in Zed)
Checklist
make gen-changelogto update the changelog.