fix: add Windows binary version info#2181
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
This was referenced May 8, 2026
421662a to
d44bca9
Compare
Author
|
Rebased this onto the latest Validation on head
The first pytest attempt hit a local Windows temp-directory permission error at |
This was referenced May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyproject.tomlkimi.specbuilds on WindowsFileVersionInfoFixes #2178.
To verify
uv run ruff check scripts/pyinstaller_version_info.py tests/test_pyinstaller_version_info.pyuv run pytest tests/test_pyinstaller_version_info.py -quv run pyright scripts/pyinstaller_version_info.py tests/test_pyinstaller_version_info.pyuv run python scripts/pyinstaller_version_info.py --output dist/kimi_version_info.test.txtuv run pyinstaller --noconfirm kimi.spec(Get-Item dist\\kimi.exe).VersionInfo | Format-List FileVersion,ProductVersion,FileDescription,ProductName,CompanyName,OriginalFilenamedist\\kimi.exe --help