Skip to content

fix(term): fail cleanly on Windows#2210

Open
he-yufeng wants to merge 1 commit into
MoonshotAI:mainfrom
he-yufeng:fix/windows-term-toad-unsupported
Open

fix(term): fail cleanly on Windows#2210
he-yufeng wants to merge 1 commit into
MoonshotAI:mainfrom
he-yufeng:fix/windows-term-toad-unsupported

Conversation

@he-yufeng
Copy link
Copy Markdown

@he-yufeng he-yufeng commented May 9, 2026

Summary

  • make kimi term exit before launching Toad on Windows
  • explain that Toad's terminal backend currently depends on POSIX-only modules such as fcntl
  • add regression coverage so the Windows path does not try to import/resolve Toad

Closes #2202

To verify

  • python -m uv run pytest tests\acp\test_toad_cli.py tests\acp\test_server_initialize.py -q
  • python -m uv run ruff check src\kimi_cli\cli\toad.py tests\acp\test_toad_cli.py
  • python -m py_compile src\kimi_cli\cli\toad.py tests\acp\test_toad_cli.py
  • git diff --check

Open in Devin Review

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kimi term crashes on Windows due to missing fcntl module, followed by secondary rich.pretty rendering error

1 participant