chore: add job to publish python package in release workflow#5
Merged
Conversation
Signed-off-by: Richard Chien <stdrc@outlook.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new job to the GitHub Actions release workflow to automatically publish Python packages to PyPI when a release is created.
Key Changes
- Adds a
publish-pythonjob that builds and publishes Python distributions to PyPI - Configures Python 3.13 and the
uvbuild tool for package creation - Uses PyPI API token authentication for secure package publishing
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| publish-python: | ||
| name: Publish Python package |
There was a problem hiding this comment.
The publish-python job lacks a needs clause to specify dependencies on other jobs. If this job should only run after successful completion of previous jobs (like building or testing), add a needs field to ensure proper job sequencing in the release workflow.
Suggested change
| name: Publish Python package | |
| name: Publish Python package | |
| needs: build |
stdrc
added a commit
that referenced
this pull request
Dec 26, 2025
albertwyjoy-bit
pushed a commit
to albertwyjoy-bit/OKbot
that referenced
this pull request
Feb 8, 2026
RealKai42
added a commit
that referenced
this pull request
Apr 20, 2026
Addresses four real issues flagged by automated reviewers on PR #1802: #6 (Codex P1): agent timeout_s was passed to BackgroundAgentRunner but never persisted on TaskSpec, so Print's wait-cap calculation always fell back to agent_task_timeout_s and silently ignored user-supplied per-agent timeouts. create_agent_task now writes the effective timeout onto the spec (same way bash tasks already do). #5 (Devin critical): the pending-notification re-entry run_soul call was bare, unlike the protected timeout follow-up. A transient ChatProviderError during the internal notification turn would propagate to the outer handler and reclassify the user's already- successful command to RETRYABLE/FAILURE. Wrap in try/except; let RunCancelled bubble (Ctrl+C semantics) and swallow anything else, exiting the wait loop so the original SUCCESS exit code is preserved. #9 (Codex P2): if the last background task transitioned to terminal in the race window between the has_active_tasks() snapshot and the deadline check, the loop took the kill + FAILURE path spuriously. Add a final reconcile + pending/active re-check inside the deadline branch so near-deadline natural completions exit via the success path. #8 (Devin yellow): the finally block's manager.reconcile() could replace a propagating RunCancelled with a disk-IO OSError, bypassing the outer except RunCancelled and surfacing as "Unknown error". Wrap the reconcile in try/except so the cancel path is preserved. Tests: - test_create_agent_task_persists_timeout_s_on_spec - test_create_agent_task_persists_default_timeout_on_spec - test_pending_reentry_soul_failure_preserves_success_exit_code - test_timeout_finally_reconcile_failure_preserves_run_cancelled - test_timeout_race_natural_completion_at_deadline_exits_success
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.