fix(tui): keep waiting spinner during encrypted reasoning streams#1256
Merged
Conversation
Empty (encrypted/redacted) thinking deltas no longer switch out of waiting mode, which previously stopped the moon spinner while no thinking component was ever created, leaving a blank spinner-less gap until the first real text/tool token.
🦋 Changeset detectedLatest commit: c1e5a89 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue — see the Problem section below.
Problem
When reasoning is encrypted/redacted (e.g. Kimi over the Anthropic-compatible protocol), the model streams thinking deltas whose visible text is empty — only an opaque signature rides along. The TUI switched into
thinkingpane mode on the first such delta, which stopped the waiting moon spinner even though no thinking component was ever created (a thinking component needs visible text). The result was a blank, spinner-less gap until the first real text/tool token arrived.What changed
Ignore empty thinking deltas while no thinking draft exists, so the waiting moon spinner stays up until actual thinking text (or the next token) arrives. Added a regression test that streams empty (encrypted) thinking deltas and asserts the moon frame keeps rendering with no orphan thinking component.
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.