refactor(web): show an up arrow on the composer send button#1301
Conversation
🦋 Changeset detectedLatest commit: 73a6044 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7fd9642cb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| download: 'download-line', | ||
| undo: 'arrow-go-back-line', | ||
| send: 'send-plane-line', | ||
| send: 'arrow-up-line', |
There was a problem hiding this comment.
When this icon mapping changes, the generated design-system catalog needs to move with it: apps/kimi-web/AGENTS.md says design-system.html is the canonical visual spec and that modified UI must match it, but I checked apps/kimi-web/design/design-system.html:1065 and the shipped apps/kimi-web/public/design-system.html:1064, and both still render send as the old paper-plane path. This leaves the documented/servable icon registry out of sync with the committed registry until the catalog copies are regenerated or updated.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 73a6044 — regenerated the design-system icon catalog from the updated registry so send now renders the up-arrow in both design-system.html copies.
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
…nce (#1302) * docs(web): add anti-slop design guidance inspired by taste-skill Codify one icon family (Remix) with no hand-rolled SVG in §02. Expand the banned AI-tell list in §01 (AI-purple/blue glow, infinite-loop micro-animations). Add button and form contrast requirements to §08. Add a 'declare design intent (Design Read) first' callout. * docs(web): resolve merge conflict with main Reset design-system.html to latest main (which includes the merged #1300 and #1301) and re-apply the taste-skill design guidance on top, so the branch merges cleanly. * docs(web): translate design system to English Translate the entire design-system.html from Chinese to English, preserving all HTML structure, CSS, code blocks, SVGs, the scroll-spy script, and token values. The design system is now a single English document.
1 participant
Related Issue
No linked issue — small follow-up to #1293 (web icon switch to Remix Icon).
Problem
The composer send button used the
sendicon, which mapped to a paper-plane glyph (send-plane-line). The request is for the send button to read as an upward arrow instead.What changed
Remapped the
sendicon toarrow-up-lineand regenerated the icon data. The send button (the only consumer of thesendicon) now renders an upward arrow. The design-system reference was updated separately in #1300 to match.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.