fix(tui): drain terminal input before exit#314
Merged
Conversation
🦋 Changeset detectedLatest commit: fa3c251 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue; this fixes a terminal cleanup bug reported during
/exit.Problem
When Kitty keyboard protocol reports Enter key release events, exiting immediately after
/exitcan let a late release sequence reach the parent shell, leaving raw CSI-u text in the VS Code terminal.What changed
The TUI now drains terminal input before stopping the UI and exiting, preserving existing shutdown cleanup while preventing late keyboard release events from leaking. A regression test covers the shutdown order, and a changeset records the CLI patch.
Validation
pnpm exec vitest run apps/kimi-code/test/tui/signal-handlers.test.ts apps/kimi-code/test/tui/kimi-tui-message-flow.test.ts apps/kimi-code/test/tui/components/editor/custom-editor.test.tspnpm exec oxlint --type-aware apps/kimi-code/src/tui/kimi-tui.ts apps/kimi-code/test/tui/signal-handlers.test.tsgit diff --check origin/main...HEADpnpm run typecheckChecklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update. No doc update is needed for this terminal cleanup fix.