fix: resume subagents lazily#380
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: bd29df1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
c806026 to
bd29df1
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue; this addresses session resume work for persisted subagents.
Problem
Reopening a session eagerly replayed persisted subagents even when callers only needed the main agent. Several RPC and subagent paths also assumed referenced agents were already instantiated, which prevented persisted subagents from being restored only when they are accessed.
What changed
ensureAgentResumedpath.Verification
pnpm --filter @moonshot-ai/agent-core typecheckpnpm --filter @moonshot-ai/agent-core exec vitest run test/session/subagent-host.test.ts test/session/init.test.ts test/tools/agent.test.ts test/harness/runtime.test.ts test/harness/skill-session.test.tsChecklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.