chore: drop personal names from source — cross-ref by issue number#233
Merged
Conversation
Renames test fixtures + classes + file from "Bernhard*" to "*MatVis285_*" / "*RegressionGrid". Pure source-hygiene; no behavioral changes. Cross-references preserved as mat-vis#NNN / py-mat#NNN.
Audit on previous round listed only the test-suite cluster + render- adapter docstrings. These four were out-of-scope for that pass but caught by a final post-rename grep: - src/pymat/core.py:355 — deprecation comment - scripts/check_pep_naming.py:8 — module docstring - tests/test_chainable_rename.py:2 — module docstring - .github/workflows/ci.yml:326 — CI step comment All "Bernhard's py-mat #218" → "py-mat#218" — issue cross-ref preserved, personal name dropped. Same pattern as the rest of this PR. Tested: tests/test_chainable_rename.py still passes (13/13).
gerchowl
force-pushed
the
chore/source-rename-drop-personal-names
branch
from
497b9d7 to
2ba378b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pure source-hygiene rename: drop personal names ("Bernhard"/"Bernhard's") from test fixtures, class names, test method, file name, and one release-please reviewer-checklist entry. All cross-references are preserved as
mat-vis#NNN/py-mat#NNN.tests/test_visual_regression.py:BERNHARD_TEXTURED→TEXTURED_REGRESSION_GRID,BERNHARD_SCALAR_ONLY→SCALAR_ONLY_REGRESSION_GRID, fiveTestBernhardMatVis285_*classes →TestMatVis285_*, artifact filenamesbernhard_grid_*→mat_vis_285_grid_*.git mv:tests/test_vis_bernhard_repros.py→tests/test_mat_vis_311_313_repros.py(93% similarity preserved).test_bernhards_workaround_no_longer_needed→test_workaround_no_longer_needed.tests/test_consumer_journey.py,tests/test_vis_inheritance.py,tests/test_e2e_vis.py,tests/test_substrate_repros.py,tests/test_error_messages.py,tests/visual_grid_render.html, plus thebernhard_285_grid_*.pngreviewer-checklist entry inrelease-please-config.json.Test plan
uv run pytest --tb=short -qgreen: 906 passed, 54 skipped, 11 xfailed.grepfortest_vis_bernhard_reprosacross the tree is empty.test_visual_regression.py,visual_grid_render.html,release-please-config.json, the renamedtest_mat_vis_311_313_repros.py,test_consumer_journey.py,test_vis_inheritance.py,test_e2e_vis.py,test_substrate_repros.py,test_error_messages.py).