Closed
Conversation
Author
|
Hi @MorganJamesSmith I rebased your branch. Do you want to take this and re-propose your PR? If you don't want to bother I can also merge my branch directly but it is better for the record if your contribution comes from you. Thanks again! |
Author
|
it would also be better if your PR comes from a branch not named "master". But no big deal. |
Went from 708 checkdoc warnings to 21. to squash
MorganJamesSmith
force-pushed
the
master
branch
2 times, most recently
from
a6f684c to
fd1cac4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.