fix(storage,upload): validate content ids + enforce multipart file limits#103
Merged
Merged
Conversation
…mits Re-derived per-concern slice from the closed #88 (resource-server input bounds). - download (/files/:cid): validate the content id against supported formats (sha256 hex, IPFS CIDv0, CIDv1 base32) before hitting any storage backend — rejects attacker-controlled identifiers + avoids oversized arbitrary IPFS lookups. Returns 400 "invalid" instead of passing junk to the backend. - upload (/upload): pass explicit multipart limits to request.file() (fileSize 10MiB, files 1, fields 0, parts 1) so oversized/multi-part uploads are rejected before any storage write. - Tests updated to use valid CIDs (the old fixtures used non-CID strings the new validator rejects) + new coverage for non-hex CID + over-limit upload. Deliberately dropped a `metrics` config fixture that #88 had entangled into these test files (it belongs to the gated config-production PR). Config-compatible, facilitator-only. Verified: typecheck clean, 461 root tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-derived per-concern slice from the closed #88 — resource-server input bounds.
/files/:cid): validate the content id against supported formats (sha256 hex, IPFS CIDv0, CIDv1 base32) before hitting any storage backend — rejects attacker-controlled identifiers and avoids oversized arbitrary IPFS lookups. Returns 400 "invalid" instead of passing junk downstream./upload): pass explicit multipart limits torequest.file()(fileSize 10 MiB, files 1, fields 0, parts 1) so oversized/multi-part uploads are rejected before any storage write.Scope discipline
Dropped a
metricsconfig fixture #88 had entangled into these test files (caught bytsc— that field belongs to the gated config-production PR, not here).Risk
Low: facilitator-only, config-compatible, tighter input validation on resource-server routes. Verified: typecheck clean, 461 root tests pass.
Part of re-delivering #88's hardening as focused, individually-reviewable PRs.
🤖 Generated with Claude Code