Skip to content

feat: Alignment fix#82

Closed
prateek-who wants to merge 1 commit intoMorpheApp:devfrom
prateek-who:alignment-fix
Closed

feat: Alignment fix#82
prateek-who wants to merge 1 commit intoMorpheApp:devfrom
prateek-who:alignment-fix

Conversation

@prateek-who
Copy link
Copy Markdown
Contributor

I was unable to replicate the installation issue however this should fix the alignment issue of apks. Instead of using the zip method which would destroy the zip alignment, we simply use apkzlib's zfile to delete unwanted native libraries and call realign() with the same rules used in patching.

@LisoUseInAIKyrios
Copy link
Copy Markdown
Contributor

Is this confirmed to fix the issue? If so can merge now.

@prateek-who
Copy link
Copy Markdown
Contributor Author

This does fix the alignment issues, however I couldn't test it since i was not able to replicate the issue. Would be better if someone could test it just in case

@LisoUseInAIKyrios
Copy link
Copy Markdown
Contributor

If anyone has this issue and can reproduce, please try the artifact from this PR:
https://github.com/MorpheApp/morphe-cli/actions/runs/23213045277/artifacts/5972612168

@wchill
Copy link
Copy Markdown
Contributor

wchill commented Mar 18, 2026

we are probably better off fixing it here and then bumping the patcher: MorpheApp/morphe-patcher#83

this also allows us to share code between CLI and manager

@prateek-who
Copy link
Copy Markdown
Contributor Author

The manager also allows for striplibs right? How does it handle this?

@wchill
Copy link
Copy Markdown
Contributor

wchill commented Mar 19, 2026

It has its own separate implementation that I think also involves post processing the patched apk. But if patcher handles it, the process will be faster because then it doesn't have to zip up the unneeded native libs in the first place only for them to get removed

@prateek-who
Copy link
Copy Markdown
Contributor Author

prateek-who commented Mar 19, 2026

Yea, that is a much better approach. So, now when the striplibs flag is called, I simply pass the apk along with the striplibs variable which specifies the set of archs to keep and then the patcher will handle it right?

@wchill
Copy link
Copy Markdown
Contributor

wchill commented Mar 19, 2026

I'm introducing a new parameter to patcherconfig called keepArchitectures. Specify whatever architectures you desire in the set. Empty set = keep everything and strip libs is disabled.

@wchill
Copy link
Copy Markdown
Contributor

wchill commented Mar 19, 2026

Gonna close this in favor of the PR using the patcher implementation

@wchill wchill closed this Mar 19, 2026
@prateek-who prateek-who deleted the alignment-fix branch March 21, 2026 05:30
wchill added a commit that referenced this pull request Mar 30, 2026
github-actions bot pushed a commit that referenced this pull request Mar 30, 2026
## [1.6.4-dev.1](v1.6.3...v1.6.4-dev.1) (2026-03-30)

### Bug Fixes

* Use patcher implementation of strip libs ([#83](#83)) ([43f50ea](43f50ea)), closes [#80](#80) [#82](#82)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants