Conversation
|
Is this confirmed to fix the issue? If so can merge now. |
|
This does fix the alignment issues, however I couldn't test it since i was not able to replicate the issue. Would be better if someone could test it just in case |
|
If anyone has this issue and can reproduce, please try the artifact from this PR: |
|
we are probably better off fixing it here and then bumping the patcher: MorpheApp/morphe-patcher#83 this also allows us to share code between CLI and manager |
|
The manager also allows for striplibs right? How does it handle this? |
|
It has its own separate implementation that I think also involves post processing the patched apk. But if patcher handles it, the process will be faster because then it doesn't have to zip up the unneeded native libs in the first place only for them to get removed |
|
Yea, that is a much better approach. So, now when the striplibs flag is called, I simply pass the apk along with the striplibs variable which specifies the set of archs to keep and then the patcher will handle it right? |
|
I'm introducing a new parameter to patcherconfig called keepArchitectures. Specify whatever architectures you desire in the set. Empty set = keep everything and strip libs is disabled. |
|
Gonna close this in favor of the PR using the patcher implementation |
I was unable to replicate the installation issue however this should fix the alignment issue of apks. Instead of using the zip method which would destroy the zip alignment, we simply use apkzlib's zfile to delete unwanted native libraries and call realign() with the same rules used in patching.