循环的最后一个元素和下一次循环的第一个元素时间不连续#66
Merged
MorvanZhou merged 1 commit intoMorvanZhou:masterfrom Dec 3, 2018
jingege315:patch-1
Merged
循环的最后一个元素和下一次循环的第一个元素时间不连续#66MorvanZhou merged 1 commit intoMorvanZhou:masterfrom jingege315:patch-1
MorvanZhou merged 1 commit intoMorvanZhou:masterfrom
jingege315:patch-1
Conversation
steps = np.linspace(start, end, TIME_STEP, dtype=np.float32) 其中默认参数endpoint=True，也就是说这一次循环的最后一个元素和下一次循环的第一个元素是一致的，按照RNN传递的state的特点，应该保证输入是关于时间连续的，所以不应该有相邻的时间是一致的情况，这可能不是想要的，所以我认为这里是一个小bug。
Owner
|
谢谢指出问题，我已将您的修改提交。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
steps = np.linspace(start, end, TIME_STEP, dtype=np.float32)
其中默认参数endpoint=True，也就是说这一次循环的最后一个元素和下一次循环的第一个元素是一致的，按照RNN传递的state的特点，应该保证输入是关于时间连续的，所以不应该有相邻的时间是一致的情况，这可能不是想要的，所以我认为这里是一个小bug。