Feature/save interfaces #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently missing some constructor parameters for HttpClient initialization.
Additionally, expose a static class SaveFile with the method CreateGZipJsonFile. This returns a SaveFile using File Input/Output, Json Serialization and GZip compression. This is likely how the SaveFile will mostly be used.
Now you can call this method with a JsonSerializerContext or JsonTypeInfo parameter.
The HttpIO is ready for the field! It now exposes the necessary headers and optional Request uris, some easy-to-use constructors and properly disposes its objects.
We need to compress the memory stream and leave it open BEFORE writing it with our IAsyncIOStreamProvider. Note that this isn't a completely correct name, since it doesn't provide a write / input stream, it accepts one. Will need to change this once a good name has been devised.
Gzip should be GZip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides interfaces for mixing and matching save / load behaviour to an Input/Output source, using any type of serialization, using any kind of compression.
The interfaces have already been implemented into the SaveFile, doing away with the events for onSave and onLoad. I feel that these events provide little benefit that can easily be recreated by anyone who needs the old behaviour. I will provide an upgrade tutorial if deemed necessary.
This is still a draft. Documentation and tests need still be provided, but the implementation may already be reviewed.