Skip to content

Step 1 for new mostro-core gift wrap: aligned nostr-sdk and mostro-core to latest version#63

Merged
arkanoider merged 1 commit into
mainfrom
chore/bump-mostro-core-0.10.1
May 7, 2026
Merged

Step 1 for new mostro-core gift wrap: aligned nostr-sdk and mostro-core to latest version#63
arkanoider merged 1 commit into
mainfrom
chore/bump-mostro-core-0.10.1

Conversation

@arkanoider
Copy link
Copy Markdown
Collaborator

@arkanoider arkanoider commented May 7, 2026

Summary:

-Bump mostro-core to 0.10.1 and align nostr-sdk to 0.44.1
-Mechanical Timestamp::as_u64 → Timestamp::as_secs fixes

Summary by CodeRabbit

Chores

  • Updated mostro-core from version 0.8.0 to 0.10.1 for enhanced core functionality and improved stability.
  • Updated nostr-sdk from version 0.43.0 to 0.44.1 to ensure compatibility with latest protocol standards and implementations.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5378936e-b64c-4945-bf37-69032b73293a

📥 Commits

Reviewing files that changed from the base of the PR and between b5adb0b and 3d5e06e.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (6)
  • Cargo.toml
  • src/util/chat_utils.rs
  • src/util/dm_utils/dm_helpers.rs
  • src/util/dm_utils/mod.rs
  • src/util/mostro_info.rs
  • src/util/order_utils/helper.rs

Walkthrough

This PR updates nostr-sdk and mostro-core dependencies, then systematically migrates all timestamp conversions across utility modules from the older as_u64() method to the newer as_secs() API. The changes are applied consistently to chat gift wraps, direct messages, instance metadata, and order parsing.

Changes

Timestamp API Modernization

Layer / File(s) Summary
Dependency Version Updates
Cargo.toml
mostro-core bumped to 0.10.1 and nostr-sdk bumped to 0.44.1 with existing feature flags preserved.
Chat Gift Wrap Timestamp Conversions
src/util/chat_utils.rs
unwrap_giftwrap_with_shared_key and fetch_gift_wraps_for_shared_key now use as_secs() for inner event timestamps and 7-day lookback window computation.
DM Utility Timestamp Migrations
src/util/dm_utils/dm_helpers.rs, src/util/dm_utils/mod.rs
ensure_order_giftwrap_subscription fallback, parse_dm_events filtering, and fetch_and_replay_startup_trade_dms cursor calculations all converted to as_secs().
Instance Info and Order Timestamp Conversions
src/util/mostro_info.rs, src/util/order_utils/helper.rs
Instance stale checks via format_instance_info_age and is_stale, plus parse_disputes_events and parse_orders_events now use as_secs() for all timestamp assignments.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Timestamps hop through time anew,
From as_u64() to seconds true,
Each utility sings in harmony,
With nostr-sdk's symphony! 🎵

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main objectives: dependency version upgrades (mostro-core 0.10.1, nostr-sdk 0.44.1) and the associated mechanical code changes (Timestamp::as_u64 to as_secs replacements).
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-mostro-core-0.10.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@arkanoider
Copy link
Copy Markdown
Collaborator Author

@CodeRabbit review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@arkanoider arkanoider merged commit 1fa8e4d into main May 7, 2026
11 checks passed
@arkanoider arkanoider deleted the chore/bump-mostro-core-0.10.1 branch May 7, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant