Revert "change payment_method type to string array"

[grunch]

Reverts #128

Summary by CodeRabbit

• Refactor

  • Updated handling of payment method fields throughout the app, switching from collections of payment methods to single string values.
  • Adjusted display of payment methods in order tables and previews to use the new format.

• Chores

  • Downgraded a core dependency version for compatibility.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This change updates the handling of the payment_method field throughout the codebase, switching from a vector of strings to a single string representation. The related code for splitting, serializing, and displaying multiple payment methods is removed or simplified. Additionally, the mostro-core dependency is downgraded from version 0.6.41 to 0.6.40.

Changes

File(s)	Change Summary
Cargo.toml	Downgraded mostro-core dependency from 0.6.41 to 0.6.40.
src/cli/new_order.rs	Changed payment_method parameter from &str to &String; removed splitting and collecting into a vector.
src/db.rs	Removed JSON serialization of payment_method; now stores as a single string directly.
src/nip33.rs	Refactored tag parsing: now expects single string for payment_method, removed vector handling, changed error handling.
src/pretty_table.rs	Changed display logic to use to_string() on payment_method instead of joining a vector.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CLI
    participant DB
    participant NIP33

    User->>CLI: Provide payment_method as String
    CLI->>DB: Store payment_method as String (no split/JSON)
    CLI->>NIP33: Parse tags, extract payment_method as String
    NIP33-->>CLI: Return parsed order
    CLI->>User: Display payment_method using to_string()

Loading

Possibly related PRs

• MostroP2P/mostro-cli#128: Replaced payment_method handling from a single string to a vector; this PR reverses those changes.
• MostroP2P/mostro-cli#93: Also modifies the execute_new_order function, though focusing on different parameters.
• MostroP2P/mostro-cli#125: Changes the mostro-core dependency version, related at the dependency management level.

Suggested reviewers

• arkanoider

Poem

A single string for payment’s way,
No more lists to lead astray.
Simpler code, less to store,
One method now—no need for more!
Downgraded core, a gentle hop,
This bunny’s work will never stop!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a67db1 and f3f21b5.

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (5)

• Cargo.toml (1 hunks)
• src/cli/new_order.rs (1 hunks)
• src/db.rs (1 hunks)
• src/nip33.rs (1 hunks)
• src/pretty_table.rs (3 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.