Change default value of max_routing_fee

[grunch]

Summary by CodeRabbit

• Chores
  • Updated maximum Lightning routing fee tolerance from 0.1% to 0.2%.

[coderabbitai]

Warning

Rate limit exceeded

@grunch has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 48 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b2f86fb6-69c4-41bd-be92-9711f5a51c03

📥 Commits

Reviewing files that changed from the base of the PR and between ff69d0e and 3a7c3d6.

📒 Files selected for processing (1)

• docs/LIGHTNING_OPS.md

Walkthrough

The maximum routing fee tolerance for Lightning payments was increased from 0.001 (0.1%) to 0.002 (0.2%) across configuration templates, default settings, tests, and documentation to accommodate higher fee calculations for small payment amounts.

Changes

Cohort / File(s)	Summary
Configuration and Defaults settings.tpl.toml, src/config/types.rs, src/config/mod.rs	Updated max_routing_fee default value from 0.001 to 0.002 in template configuration and type defaults; test fixture and assertion updated to reflect new default.
Documentation README.md, docs/STARTUP_AND_CONFIG.md, docs/LIGHTNING_OPS.md	Updated routing fee tolerance references from 0.1% to 0.2% in configuration examples and Lightning operations documentation; fee-limit calculation for small amounts increased from 1% to 2%.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• Settings refactor #481: Directly modifies the same MostroSettings::max_routing_fee default value in source configuration types.
• feat: add development fund configuration infrastructure #555: Also updates MostroSettings default configuration values and fields.
• docs: add comprehensive technical documentation #553: Modifies related Lightning payment fee-limit documentation and logic in docs/LIGHTNING_OPS.md.

Suggested reviewers

• arkanoider
• Catrya
• AndreaDiazCorreia

Poem

🐰 Fee limits hop a bit more high,
Two basis points reach for the sky,
Small payments dance with careful grace,
A gentle change throughout this place.
Configuration hops align,
Now routing fees are twice as fine! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title 'Change default value of max_routing_fee' accurately and specifically describes the main change across the entire changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch change-default-max_routing_fee

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/LIGHTNING_OPS.md`:
- Line 151: The documentation line showing "Ordering::Less | Ordering::Equal =>
amount as f64 * 0.02,  // 2%" is out of sync with the runtime send_payment()
logic; update this docs section to reflect the actual fee calculation used by
send_payment() in src/lightning/mod.rs (1% of amount with a minimum of 10 sats)
or, if you prefer to change runtime, adjust the send_payment() fee calculation
to 2% to match the docs—specifically reference the fee branch in send_payment()
and the Ordering::Less | Ordering::Equal case so the comment and prose match the
implemented formula and minimum.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8f8aedfb-d756-485c-9b82-45180abab663

📥 Commits

Reviewing files that changed from the base of the PR and between 122ff24 and ff69d0e.

📒 Files selected for processing (6)

• README.md
• docs/LIGHTNING_OPS.md
• docs/STARTUP_AND_CONFIG.md
• settings.tpl.toml
• src/config/mod.rs
• src/config/types.rs